Skip to content

Update to aiokef=0.2.5 which uses Locks#30753

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
basnijholt:update-aiokef
Jan 14, 2020
Merged

Update to aiokef=0.2.5 which uses Locks#30753
pvizeli merged 1 commit into
home-assistant:devfrom
basnijholt:update-aiokef

Conversation

@basnijholt
Copy link
Copy Markdown
Contributor

Description:

Updates aiokef to 0.2.3 and sets the PARALLEL_UPDATES correctly.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@basnijholt basnijholt changed the title Update aiokef=0.2.3 Update aiokef=0.2.4 and set PARALLEL_UPDATES=1 Jan 14, 2020
Copy link
Copy Markdown
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will force multiple kef systems to execute in series instead of paralell

Since this is async lib, I think async locks are better?

@basnijholt
Copy link
Copy Markdown
Contributor Author

This will force multiple kef systems to execute in series instead of paralell

That's not how I understood it.

I will do that later, indeed! However, for now this should alleviate a problem.

@basnijholt
Copy link
Copy Markdown
Contributor Author

I've added an asyncio.Lock in aiokef==0.2.5 👍

@pvizeli pvizeli added this to the 0.104.0 milestone Jan 14, 2020
@basnijholt basnijholt changed the title Update aiokef=0.2.4 and set PARALLEL_UPDATES=1 Update to aiokef=0.2.5 which uses Locks Jan 14, 2020
@pvizeli pvizeli merged commit a26fef3 into home-assistant:dev Jan 14, 2020
balloob pushed a commit that referenced this pull request Jan 14, 2020
raman325 added a commit to raman325/home-assistant that referenced this pull request Jan 15, 2020
* upstream/dev: (82 commits)
  Add support for vacuums to Alexa. (home-assistant#30764)
  Refactor Ring data handling (home-assistant#30777)
  Restore unit_of_measurement from entity registry (home-assistant#30780)
  Update pyubee to 0.8 (home-assistant#30785)
  Update emulated_roku to 0.1.9 (home-assistant#30791)
  Add Config Flow support, Device Registry support, available property to vizio component (home-assistant#30653)
  Allow input_* and timer component setup without config (home-assistant#30772)
  Search: Add search to default config and don't resolve area (home-assistant#30762)
  [ci skip] Translation update
  Use storage based collections for Timer platform (home-assistant#30765)
  Upgrade youtube_dl to version 2020.01.15 (home-assistant#30767)
  Whitelist Frenck for release
  Hass.io allow to reset password with CLI (home-assistant#30755)
  Revert home-assistant#29701 (home-assistant#30766)
  Add Safe Mode (home-assistant#30723)
  Update Ring to 0.6.0 (home-assistant#30748)
  Add support for the voltage sensor on the greeneye GEM (home-assistant#30484)
  Fix supported_features in MQTT fan (home-assistant#28680)
  Fix small typo in alarmdotcom component (home-assistant#30758)
  bump aiokef to 0.2.5 which uses locks (home-assistant#30753)
  ...
@lock lock Bot locked and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants